[lkml]   [2006]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [2.6 patch] move EXPORT_SYMBOL's away from sound/pci/emu10k1/emu10k1_main.c
On Fri, Apr 07, 2006 at 02:34:56PM +0200, Takashi Iwai wrote:
> At Fri, 7 Apr 2006 02:31:05 +0200,
> Adrian Bunk wrote:
> >
> > This patch moves the EXPORT_SYMBOL's from
> > sound/pci/emu10k1/emu10k1_main.c to the files with the actual functions.
> What is the merit of this movement?

1) Documentation - it is obvious that the function/data is exported so
be a bit mroe careful when introducing changes
2) Style. In 2.6 the preferred style is to put the EXPORT_SYMBOL on the
line following the closing } of the exported function.
3) Keep changes local. If one removes a previously exported symbol less
files needs to be touched.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-04-07 20:53    [W:0.036 / U:11.232 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site