Messages in this thread |  | | | Date | Fri, 7 Apr 2006 20:49:09 +0200 | | From | Sam Ravnborg <> | | Subject | Re: [2.6 patch] move EXPORT_SYMBOL's away from sound/pci/emu10k1/emu10k1_main.c |
| |
On Fri, Apr 07, 2006 at 02:34:56PM +0200, Takashi Iwai wrote: > At Fri, 7 Apr 2006 02:31:05 +0200, > Adrian Bunk wrote: > > > > This patch moves the EXPORT_SYMBOL's from > > sound/pci/emu10k1/emu10k1_main.c to the files with the actual functions. > > What is the merit of this movement?
1) Documentation - it is obvious that the function/data is exported so be a bit mroe careful when introducing changes 2) Style. In 2.6 the preferred style is to put the EXPORT_SYMBOL on the line following the closing } of the exported function. 3) Keep changes local. If one removes a previously exported symbol less files needs to be touched. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |