Messages in this thread |  | | | Date | Wed, 05 Apr 2006 11:38:44 +0200 | | From | Tilman Schmidt <> | | Subject | Re: [2.6 patch] drivers/isdn/gigaset/common.c: small cleanups |
| |
Adrian Bunk wrote:
> This patch contains the following cleanups: > - makethe needlessly global gigaset_get_cs_by_tty() static > - remove the unused EXPORT_SYMBOL_GPL(gigaset_debugdrivers)
Thanks for catching these.
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Tilman Schmidt <tilman@imap.cc>
> > --- > > drivers/isdn/gigaset/common.c | 17 ++++++++--------- > drivers/isdn/gigaset/gigaset.h | 1 - > 2 files changed, 8 insertions(+), 10 deletions(-) > > --- linux-2.6.16-mm2-full/drivers/isdn/gigaset/gigaset.h.old 2006-04-04 00:15:36.000000000 +0200 > +++ linux-2.6.16-mm2-full/drivers/isdn/gigaset/gigaset.h 2006-04-04 00:15:42.000000000 +0200 > @@ -754,7 +754,6 @@ > /* Deallocate driver structure. */ > void gigaset_freedriver(struct gigaset_driver *drv); > void gigaset_debugdrivers(void); > -struct cardstate *gigaset_get_cs_by_minor(unsigned minor); > struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty); > struct cardstate *gigaset_get_cs_by_id(int id); > > --- linux-2.6.16-mm2-full/drivers/isdn/gigaset/common.c.old 2006-04-04 00:06:34.000000000 +0200 > +++ linux-2.6.16-mm2-full/drivers/isdn/gigaset/common.c 2006-04-04 00:16:45.000000000 +0200 > @@ -962,16 +962,8 @@ > } > spin_unlock_irqrestore(&driver_lock, flags); > } > -EXPORT_SYMBOL_GPL(gigaset_debugdrivers); > > -struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty) > -{ > - if (tty->index < 0 || tty->index >= tty->driver->num) > - return NULL; > - return gigaset_get_cs_by_minor(tty->index + tty->driver->minor_start); > -} > - > -struct cardstate *gigaset_get_cs_by_minor(unsigned minor) > +static struct cardstate *gigaset_get_cs_by_minor(unsigned minor) > { > unsigned long flags; > static struct cardstate *ret = NULL; > @@ -994,6 +986,13 @@ > return ret; > } > > +struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty) > +{ > + if (tty->index < 0 || tty->index >= tty->driver->num) > + return NULL; > + return gigaset_get_cs_by_minor(tty->index + tty->driver->minor_start); > +} > + > void gigaset_freedriver(struct gigaset_driver *drv) > { > unsigned long flags; >
-- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) [unhandled content-type:application/pgp-signature] |  |