lkml.org 
[lkml]   [2006]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 2.6.16-mm2 10/9] sched throttle tree extract - kill interactive task feedback loop
Date
On Thursday 06 April 2006 03:38, Mike Galbraith wrote:
> Greetings,
>
> The patch below stops interactive tasks from feeding off each other
> during round-robin.
>
> With this 10th patch in place, a busy server with _default_ throttle
> settings (ie tunables may now be mostly unneeded) looks like this:

> --- linux-2.6.16-mm2/kernel/sched.c-9.export_tunables 2006-03-31
> 13:37:09.000000000 +0200 +++ linux-2.6.16-mm2/kernel/sched.c 2006-04-05
> 19:22:01.000000000 +0200 @@ -3480,7 +3480,7 @@ go_idle:
> queue = array->queue + idx;
> next = list_entry(queue->next, task_t, run_list);
>
> - if (!rt_task(next) && interactive_sleep(next->sleep_type)) {
> + if (!TASK_INTERACTIVE(next) && interactive_sleep(next->sleep_type)) {

You can't remove that rt_task check from there can you? We shouldn't ever
requeue a rt task.

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-06 01:19    [W:0.052 / U:1.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site