lkml.org 
[lkml]   [2006]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 15/26] wrong error path in dup_fd() leading to oopses in RCU


    From: Kirill Korotaev <dev@openvz.org>

    [PATCH] wrong error path in dup_fd() leading to oopses in RCU

    Wrong error path in dup_fd() - it should return NULL on error,
    not an address of already freed memory :/

    Triggered by OpenVZ stress test suite.

    What is interesting is that it was causing different oopses in RCU like
    below:
    Call Trace:
    [<c013492c>] rcu_do_batch+0x2c/0x80
    [<c0134bdd>] rcu_process_callbacks+0x3d/0x70
    [<c0126cf3>] tasklet_action+0x73/0xe0
    [<c01269aa>] __do_softirq+0x10a/0x130
    [<c01058ff>] do_softirq+0x4f/0x60
    =======================
    [<c0113817>] smp_apic_timer_interrupt+0x77/0x110
    [<c0103b54>] apic_timer_interrupt+0x1c/0x24
    Code: Bad EIP value.
    <0>Kernel panic - not syncing: Fatal exception in interrupt

    Signed-Off-By: Pavel Emelianov <xemul@sw.ru>
    Signed-Off-By: Dmitry Mishin <dim@openvz.org>
    Signed-Off-By: Kirill Korotaev <dev@openvz.org>
    Signed-Off-By: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    kernel/fork.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- linux-2.6.16.1.orig/kernel/fork.c
    +++ linux-2.6.16.1/kernel/fork.c
    @@ -720,7 +720,7 @@ out_release:
    free_fdset (new_fdt->open_fds, new_fdt->max_fdset);
    free_fd_array(new_fdt->fd, new_fdt->max_fds);
    kmem_cache_free(files_cachep, newf);
    - goto out;
    + return NULL;
    }

    static int copy_files(unsigned long clone_flags, struct task_struct * tsk)
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-05 02:09    [W:0.022 / U:0.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site