lkml.org 
[lkml]   [2006]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 21/26] Fix NULL pointer dereference in node_read_numastat()
    From: Christoph Lameter <clameter@sgi.com>

    Fix NULL pointer dereference in node_read_numastat()

    zone_pcp() only returns valid values if the processor is online.

    Change node_read_numastat() to only scan online processors.

    Signed-off-by: Christoph Lameter <clameter@sgi.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/base/node.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- linux-2.6.16.1.orig/drivers/base/node.c
    +++ linux-2.6.16.1/drivers/base/node.c
    @@ -106,7 +106,7 @@ static ssize_t node_read_numastat(struct
    other_node = 0;
    for (i = 0; i < MAX_NR_ZONES; i++) {
    struct zone *z = &pg->node_zones[i];
    - for (cpu = 0; cpu < NR_CPUS; cpu++) {
    + for_each_online_cpu(cpu) {
    struct per_cpu_pageset *ps = zone_pcp(z,cpu);
    numa_hit += ps->numa_hit;
    numa_miss += ps->numa_miss;
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-05 02:05    [W:3.797 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site