Messages in this thread | | | Subject | RE: [PATCH] MPBL0010 driver sysfs permissions wide open | Date | Tue, 4 Apr 2006 16:54:08 -0700 | From | "Gross, Mark" <> |
| |
ACK.
This looks good to me.
The use case for this driver is to configure the fail over behavior of the clock hardware. That should be done by the more privileged users.
Thanks,
--mgross
>-----Original Message----- >From: Mark Bellon [mailto:mbellon@mvista.com] >Sent: Tuesday, April 04, 2006 12:32 PM >To: linux-kernel@vger.kernel.org; Gross, Mark; >sebastien.bouchard@ca.kontron.com >Subject: [PATCH] MPBL0010 driver sysfs permissions wide open > >The MPBL0010 Telco clock driver (drivers/char/tlclk.c) uses 0222 (anyone >can write) permissions on its writable sysfs entries. IMHO this is a bit >too wide open for proper security. The patch (against 2.6.16.1) alters >the permissions to 0220 (owner and group can write). > >Signed-off-by: Mark Bellon <mbellon@mvista.com> > >mark > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |