lkml.org 
[lkml]   [2006]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.17-rc1-mm1: KEXEC became SMP-only
Adrian Bunk wrote:
> On Tue, Apr 04, 2006 at 01:45:04AM -0700, Andrew Morton wrote:
>
>> ...
>> Changes since 2.6.16-mm2:
>> ...
>> +x86-clean-up-subarch-definitions.patch
>> ...
>> x86 updates.
>> ...
>>
>
> The following looks bogus:
>
> config KEXEC
> bool "kexec system call (EXPERIMENTAL)"
> - depends on EXPERIMENTAL
> + depends on EXPERIMENTAL && (!X86_VOYAGER && SMP)
>
> The dependencies do now say that KEXEC is only offered for machines that
> are _both_ non-Voyager and SMP.
>
> Is the problem you wanted to express that a non-SMP Voyager config
> didn't compile?
>

Whoops, that should be

depends on EXPERIMENTAL && !(X86_VOYAGER && SMP)

Voyager SMP builds don't compile with kexec(), and it isn't clear how to
shootdown CPUs using NMIs without an APIC.
Signed-off-by: Zachary Amsden <zach@vmware.com>

Index: linux-2.6.16.1/arch/i386/Kconfig
===================================================================
--- linux-2.6.16.1.orig/arch/i386/Kconfig 2006-04-03 12:37:11.000000000 -0700
+++ linux-2.6.16.1/arch/i386/Kconfig 2006-04-04 10:18:25.000000000 -0700
@@ -813,7 +813,7 @@ source kernel/Kconfig.hz

config KEXEC
bool "kexec system call (EXPERIMENTAL)"
- depends on EXPERIMENTAL && (!X86_VOYAGER && SMP)
+ depends on EXPERIMENTAL && !(X86_VOYAGER && SMP)
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
\
 
 \ /
  Last update: 2006-04-04 19:39    [W:0.157 / U:1.184 seconds]
©2003-2014 Jasper Spaans. Advertise on this site