Messages in this thread | | | Date | Mon, 3 Apr 2006 16:44:34 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: include/asm-arm/memory.h changes break zaurus sl-5500 boot |
| |
On Mon, 3 Apr 2006 08:36:53 +0100 Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Mon, Apr 03, 2006 at 09:15:04AM +0900, KAMEZAWA Hiroyuki wrote: > > On Mon, 3 Apr 2006 00:23:14 +0200 > > Pavel Machek <pavel@ucw.cz> wrote: > > > > Not surprising given this gem: > > > > > > > > > -#define arch_local_page_offset(pfn, nid) (LOCAL_MAP_NR((pfn) << PAGE_OFFSET)) > > > > > > > > PAGE_OFFSET being 3GB - that's one hell of a shift value! > > > > > > Unfortunately this is mainline now. Is there some better fix than > > > simply reverting the offending patches? > > > > Maybe this one will fix (against 2.6.16-mm2) > > > > LOCAL_MAP_NR(kaddr) returns page offset in a node. > > LOCAL_MAP_NR does not take a kernel virtual address. If you look at how > it's defined (Eg): > > #define LOCAL_MAP_NR(addr) \ > (((unsigned long)(addr) & 0x07ffffff) >> PAGE_SHIFT) >
Hmm..from include/asm-arm/arch-clps711x/memory.h
== /* * Given a kaddr, LOCAL_MAR_NR finds the owning node of the memory * and returns the index corresponding to the appropriate page in the * node's mem_map. */ #define LOCAL_MAP_NR(addr) \ (((unsigned long)(addr) & (NODE_MAX_MEM_SIZE - 1)) >> PAGE_SHIFT) ==
Is this comment wrong ???
I already posted patch against 2.6.17-rc1. so, please NACK for it. sorry for annoying.
Thanks, -- Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |