lkml.org 
[lkml]   [2006]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86/PAE: Fix pte_clear for the >4GB RAM case
    * Andi Kleen (ak@suse.de) wrote:
    > > +static inline void pmd_clear(pmd_t *pmd)
    > > +{
    > > + u32 *tmp = (u32 *)pmd;
    > > + *tmp = 0;
    > > + smp_wmb();
    > > + *(tmp + 1) = 0;
    > > +}
    >
    > I think that's still wrong - it should be wmb() not smp_wmb because this
    > problem can happen on a UP kernel already.

    I thought the barrier is to keep compiler from reordering not processor.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-28 07:26    [W:0.021 / U:182.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site