lkml.org 
[lkml]   [2006]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] x86/PAE: Fix pte_clear for the >4GB RAM case
Date
On Friday 28 April 2006 07:23, Chris Wright wrote:
> * Andi Kleen (ak@suse.de) wrote:
> > > +static inline void pmd_clear(pmd_t *pmd)
> > > +{
> > > + u32 *tmp = (u32 *)pmd;
> > > + *tmp = 0;
> > > + smp_wmb();
> > > + *(tmp + 1) = 0;
> > > +}
> >
> > I think that's still wrong - it should be wmb() not smp_wmb because this
> > problem can happen on a UP kernel already.
>
> I thought the barrier is to keep compiler from reordering not processor.

Yes, but with smp_wmb() it will go away on UP. And even on UP the
CPU is free to speculate.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-28 08:11    [W:0.055 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site