[lkml]   [2006]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] sched: fix evaluation of skip_for_load in move_tasks()
On Wed, Apr 26, 2006 at 09:23:32AM +1000, Peter Williams wrote:
> Siddha, Suresh B wrote:
> > I think we need to change this to
> > if (skip_for_load && idx < this_best_prio && idx == busiest_best_prio)
> > skip_for_load = !busiest_best_prio_seen;
> >
> > Otherwise we will reset skip_for_load to '0' even for the tasks whose prio is
> > less than this_best_prio but not equal to busiest_best_prio.
> And why is that a problem? The intention of this code is to make sure
> at least one busiest_best_prio task doesn't get moved as a result of the
> "skip for reasons of load weight" mechanism being overridden by the "idx
> < this_best_prio" exception. I can't see how this intention is being
> subverted.

There might be scenarios where we will endup moving other priority tasks(
not those with busiest_best_prio) which will still become highest priority
on new queue. This may or may not be bad. But this was not our intention
with the intended code, right?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-04-26 02:21    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean