Messages in this thread | | | Date | Tue, 25 Apr 2006 15:39:58 -0700 | From | Greg KH <> | Subject | Re: [RFC] class_device_add needs error checks |
| |
On Fri, Apr 21, 2006 at 01:40:27PM -0700, Stephen Hemminger wrote: > + if (atomic_read(&class_dev->kobj.kref.refcount)) > + kobject_del(&class_dev->kobj);
Yeah, we can't do this, we should not be mucking around in the kref core like this.
Are you having problems where class_device_add() should be failing and it isn't?
Other than the above, the patch almost looked good :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |