lkml.org 
[lkml]   [2006]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: C++ pushback
    On Tue, 25 Apr 2006, J.A. Magallon wrote:
    > On Mon, 24 Apr 2006 22:52:12 +0100, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
    > > This is one area of concern. Just as big a problem for the OS case is
    > > that the hidden constructors/destructors may fail.
    >
    > Tell me what is the difference between:
    >
    >
    > sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
    > if (!sbi)
    > return -ENOMEM;
    > sb->s_fs_info = sbi;
    > memset(sbi, 0, sizeof(*sbi));
    > sbi->s_mount_opt = 0;
    > sbi->s_resuid = EXT3_DEF_RESUID;
    > sbi->s_resgid = EXT3_DEF_RESGID;
    >
    > and
    >
    > SuperBlock() : s_mount_opt(0), s_resuid(EXT3_DEF_RESUID), s_resgid(EXT3_DEF_RESGID)
    > {}
    >
    > ...
    > sbi = new SuperBlock;

    You forgot the `nothrow'.

    > if (!sbi)
    > return -ENOMEM;
    >
    > apart that you don't get members initalized twice and get a shorter code :).

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-25 20:04    [W:0.032 / U:0.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site