Messages in this thread | | | Date | Tue, 25 Apr 2006 08:26:07 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH] x86-64: trivial gart clean-up |
| |
On Tue, Apr 25, 2006 at 12:42:43AM +0200, Andi Kleen wrote:
> On Tuesday 25 April 2006 00:53, Jon Mason wrote: > > A trivial change to have gart_unmap_sg call gart_unmap_single directly, > > instead of bouncing through the dma_unmap_single wrapper in > > dma-mapping.h. This change required moving the gart_unmap_single above > > gart_unmap_sg, and under gart_map_single (which seems a more logical > > place that its current location IMHO). > > What advantage does that have? I think I prefer the old code.
I don't know what Jon had in mind, but we do avoid a call through a function pointer this way. I agree with Jon that it also makes more sense - gart code can just call the gart code directly, without going through the dma_xxx wrapper that ends up calling it anyway.
Cheers, Muli -- Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |