lkml.org 
[lkml]   [2006]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] RCU: introduce rcu_soon_pending() interface
> OK, got a look at your patch.
>
> You are using this internally, as part of the RCU -implementation-.
> You are determining whether this CPU will still be needed by RCU,
> or whether it can be turned off. So how 'bout calling the (internal)
> API something like rcu_needs_cpu()?
>
> int rcu_needs_cpu(int cpu)
> {
> struct rcu_data *rdp = &per_cpu(rcu_data, cpu);
> struct rcu_data *rdp_bh = &per_cpu(rcu_bh_data, cpu);
>
> return (!!rdp->curlist || !!rdp_bh->curlist || rcu_pending(cpu));
> }
>
> Then you can drop the rcu_pending() check from your 390 patch.
>
> Seem reasonable?

Looks fine to me! Will you post a patch or should I?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-25 13:54    [W:0.065 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site