lkml.org 
[lkml]   [2006]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 4/4] change slab poison pattern
From
Date
Hi,

On Mon, 2006-04-24 at 16:33 +0800, Akinobu Mita wrote:
> kref debugging cannot detect kref_put() with unreferenced object,
> when the structure including kref is allocated by slab
> and slab debugging config is enabled.
>
> Because use-after-free poisoning make kref counter signed value.
> So this patch prevents it by changing poisoning pattern.

Then why not check against POISON_INUSE when CONFIG_SLAB_DEBUG in the
kref debugging code? I would prefer you didn't change the slab constants
(they're well known by everyone now) but if you must, at least stick a
big fat comment there.

Pekka

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-24 11:22    [W:0.787 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site