lkml.org 
[lkml]   [2006]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
On 4/23/06, Andrew Morton <akpm@osdl.org> wrote:
> Jesper Juhl <jesper.juhl@gmail.com> wrote:
> >
> > Here's a patch that does a CodingStyle cleanup of fs/binfmt_elf.c and also
> > removes some pointless casts of kmalloc() return values in the same file.
> >
>
> Much-needed.
>
Nice to know that doing it was worthwhile :)


[snip]
> The typecasting for NEW_AUX_ENT is random, ugly, irrational and
> undesirable. It's always u32 or unsigned long. Perhaps as a followup
> patch you could look at removing the unneeded casts? (hopefully that'll
> be all of them)
>
Sure, I'll take a look at that this evening, hopefully that'll mean a
follow-up patch in aproximately 12-16hrs.


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-24 09:18    [W:0.077 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site