lkml.org 
[lkml]   [2006]   [Apr]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 24 Apr 2006 10:45:31 -0400
From"Dmitry Torokhov" <>
SubjectRe: [RFC] [PATCH] Make ACPI button driver an input device
On 4/19/06, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Wed, Apr 19, 2006 at 10:04:47PM +0200, Dominik Brodowski wrote:
> > On Wed, Apr 19, 2006 at 08:53:58PM +0100, Matthew Garrett wrote:
> > > +++ a/include/linux/input.h 2006-04-19 20:49:18 +0100
> > > @@ -344,6 +344,7 @@> > >  #define KEY_FORWARDMAIL            233
> > >  #define KEY_SAVE           234
> > >  #define KEY_DOCUMENTS              235
> > > +#define KEY_LID                    237> >> > What about 236?>> I sent a patch last month that uses 236 for KEY_BATTERY, so decided not
> to conflict with it.>

Yes, I still need to apply it.

Matthew, I would recommend not adding KEY_LID but using one of the
switch codes (SW_0?) for the lid.

Richard, on your handhelds what switch would be most similar to
notebook's lid? Should we alias one of the switches to SW_LID?

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-24 16:47    [from the cache]
©2003-2008