Messages in this thread | | | Date | Sat, 22 Apr 2006 16:44:33 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH] 'make headers_install' kbuild target. |
| |
On Sat, Apr 22, 2006 at 03:26:14PM +0100, David Woodhouse wrote: > On Sat, 2006-04-22 at 16:11 +0200, Adrian Bunk wrote: > > Sorry, but I'm not a fan of doing much more work than required instead > > of getting a consensus first and then implementing the solution. > > It _isn't_ significantly more work. The _real_ work is in reading > through the header files and deciding which parts should be private and > which can be public, then splitting them up accordingly into separate > files (or using 'ifdef __KERNEL__' if appropriate). That's the kind of > thing that you seem particularly good at, which is why I've asked if you > could help us with it. > > Moving the public files from one directory to another, if they've been > suitably marked or listed somewhere, is _trivial_. Even if you've used > #ifdef __KERNEL__ it's simple enough to do it automatically with tools > like unifdef. The _real_ work which requires human attention is the same > either way.
The problem is you need #ifdef's everywhere.
If part of a header file is part of the userspace ABI, this often means that you need #ifdef __KERNEL__'s for the #include's of headers that will not be part of the userspace ABI (like linux/compiler.h).
And how do you express that in header foo.h, the userspace part requires the userspace part of bar.h, while the kernel-internal part of foo.h also requires the kernel-internal part of bar.h?
And reading through header files doesn't become easier after adding five #ifdef __KERNEL__'s to a header file.
> But if you're not willing to help, that's fine. I just thought you'd be > particularly suited to the task, that's all.
I'm sorry, but I don't like your approach.
> dwmw2
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |