Messages in this thread | | | Date | Fri, 21 Apr 2006 01:54:12 -0700 | From | Andrew Morton <> | Subject | Re: kfree(NULL) |
| |
James Morris <jmorris@namei.org> wrote: > > On Fri, 21 Apr 2006, Daniel Walker wrote: > > > I included a patch , not like it's needed . Recently I've been > > evaluating likely/unlikely branch prediction .. One thing that I found > > is that the kfree function is often called with a NULL "objp" . In fact > > it's so frequent that the "unlikely" branch predictor should be inverted! > > Or at least on my configuration. > > It would be helpful to collect some stats on this so we can look at the > ratio. >
Yes, kfree(NULL) is supposed to be uncommon. If someone's doing it a lot then we should fix up the callers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |