lkml.org 
[lkml]   [2006]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRemoving .tmp_versions considered harmful
From
Date
Hello!

A patch applied shortly after Linux 2.6.16
(fb3cbd2e575f9ac0700bfa1e7cb9f4119fbd0abd in git) causes
the .tmp_versions directory to be removed every time make is run to
build external modules.

This is bad for two reasons.

1) When "make install" is run as root, .tmp_versions is re-created and
becomes owned by root. Subsequent "make" by user fails
because .tmp_versions cannot be removed.

2) The projects where modules are build in more than one directory (such
as MadWifi) are now compiled with spurious warnings about unresolved
symbols. This happens because every module is compiled individually,
and the *.mod files for one module are removed before the other is
compiled.

In both cases, I cannot think of any sane workarounds. For the first
problem, MODVERDIR could be set to different values for different
usernames. For the second problem, I considered clever ways to sabotage
some targets based on the target name, something like:

divert_crmodverdir = some_other_dir
MODVERDIR=$(SYMBOLSDIR)'$$(divert_$$@)'

When I looked on this the next day I realized that it's ugly as hell.
Why should I invent workarounds for what should be a standard situation?

Since I don't see any better approach, I'm asking the commit
fb3cbd2e575f9ac0700bfa1e7cb9f4119fbd0abd to be reverted for Linux
2.6.17. The problem it solves (stale *.mod files) is not nearly as big
as the problems it creates.

Note that the removal on *.mod files only would not address the MadWifi
problem.

--
Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-21 06:24    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site