Messages in this thread | | | Subject | Re: kfree(NULL) | From | Steven Rostedt <> | Date | Fri, 21 Apr 2006 14:56:38 -0400 |
| |
On Fri, 2006-04-21 at 11:42 -0700, Daniel Walker wrote: > On Fri, 2006-04-21 at 14:00 -0400, Steven Rostedt wrote: > > > [ 6491] c01aafc4 - start_this_handle+0x234/0x4b0 > > [ 8404] c01aba66 - do_get_write_access+0x2e6/0x5a0 > > > IMO , these two are overloaded with goto's it makes it hard to know > whats going on . >
(I've added Stephen Tweedie to the CC list since these two functions are his)
Perhaps this patch is something that can be useful. It can tell us where we need to either fix the logic so that a kfree(NULL) doesn't happen, or it can tell us where we should have a "if (obj) kfree(obj)" since it is quicker than doing the function call.
Right now, these two locations seem to be good candidates to putting in the NULL check before calling kfree.
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |