lkml.org 
[lkml]   [2006]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] FS-Cache: Generic filesystem caching facility
David Howells <dhowells@redhat.com> wrote:
>
> > That's your fourth implementation of kenter(). Maybe we
> > need <linux/dhowells.h>?
>
> :-)
>
> Maybe I should move my debugging macros into include/linux, but then everyone
> else would complain if their own versions weren't put in there, or would
> complain if they were forced to use mine.

The number of home-made debugging macro implementations we have is quite
demented. Developing (and maintaining) a common set would be a good idea,
IMO.

> It doesn't actually produce very much code.
>
> > Defining symbols which are owned by the Kconfig system isn't very nice.
>
> Kconfig is still broken:
>
> warthog>grep -r CONFIG_FSCACHE include/linux/autoconf.h
> #define CONFIG_FSCACHE_MODULE 1
> warthog>
>
> Modules that might depend on fscache need to know that it's there,

In theory, module A isn't supposed to care whether module B was configured,
because module B might be compiled separately, or dowloaded from elsewhere
or whatever.

> and having
> to double up every #if to detect both is stupid.
>
> Would you suggest then:
>
> #if defined(CONFIG_FSCACHE) || defined(CONFIG_FSCACHE_MODULE)
> #define FSCACHE_AVAILABLE 1
> #endif

yup.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-21 20:42    [W:0.051 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site