lkml.org 
[lkml]   [2006]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH/RFC] s390: Hypervisor File System
    From
    Date
    Hi Pekka,

    > I have included some review comments below.

    First of all thank you very much for the code review! You suggestions
    sound reasonable! I will post an updated patch on Monday!

    [snip]

    > > +struct x_info_blk_hdr {
    > > + __u8 npar;
    > > + __u8 flags;
    > > + __u16 tslice;
    > > + __u16 phys_cpus;
    > > + __u16 this_part;
    > > + __u64 curtod1;
    > > + __u64 curtod2;
    > > + char reserved[40];
    > > +} __attribute__ ((packed));
    >
    > Couldn't you use endianess annotated types for these?
    >

    What are "endianess annotated types" ?

    Michael

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-21 17:02    [W:0.021 / U:0.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site