lkml.org 
[lkml]   [2006]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 10/11] security: AppArmor - Add flags to d_path
    On Wed, Apr 19, 2006 at 11:12:48PM +0100, Christoph Hellwig wrote:
    > On Wed, Apr 19, 2006 at 10:50:26AM -0700, Tony Jones wrote:
    > > This patch adds a new function d_path_flags which takes an additional flags
    > > parameter. Adding a new function rather than ammending the existing d_path
    > > was done to avoid impact on the current users.
    > >
    > > It is not essential for inclusion with AppArmor (the apparmor_mediation.patch
    > > can easily be revised to use plain d_path) but it enables cleaner code
    > > ["(delete)" handling] and closes a loophole with pathname generation for
    > > chrooted tasks.
    > >
    > > It currently adds two flags:
    > >
    > > DPATH_SYSROOT:
    > > d_path should generate a path from the system root rather than the
    > > task's current root.
    > >
    > > For AppArmor this enables generation of absolute pathnames in all
    > > cases. Currently when a task is chrooted, file access is reported
    > > relative to the chroot. Because it is currently not possible to
    > > obtain the absolute path in an SMP safe way, without this patch
    > > AppArmor will have to report chroot-relative pathnames.
    >
    > This is utter bullshit. There is no such thing as a system root,
    > and should not rely on pathes making any sense for anything but the
    > process using at at this point of time. This stuff will not get in either
    > in d_path or whatever duplicate of it you'd try to submit.

    You are correct on calling BS in that I was wrong to refer to it as the
    "system root". When a task chroots relative to it's current namespace, we
    are interested in the path back to the root of that namespace, rather than
    to the chroot. I believe the patch as stands achieves this, albeit with
    some changing of comments.

    thanks!

    Tony
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-20 07:43    [W:0.030 / U:0.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site