[lkml]   [2006]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] i2c-i801: Fix resume when PEC is used
Hi Linus,

> On Wed, 19 Apr 2006, Jean Delvare wrote:
> > The BIOS of the Tecra M2 doesn't like it when it has to reboot or
> > resume after the i2c-i801 driver has left the SMBus in PEC mode. The
> > most simple fix is to clear the PEC bit after after every transaction.

The same day, Linus Torvalds replied:
> Just wondering.. Wouldn't it make more sense to clear it when closing the
> device or when shutting down, rather than after each transaction?

That's what my original patch was doing, but Mark M. Hoffman objected
that it didn't cover the case where the user hits the reset button.

Given that PEC is only rarely used, the slight performance impact isn't
an issue, so I'm fine with both patches.

Jean Delvare
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-04-19 20:33    [W:0.046 / U:2.796 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site