Messages in this thread | | | Date | Mon, 17 Apr 2006 22:13:45 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] net driver: Add support for SMSC LAN911x line of ethernet chips |
| |
"Dustin McIntire" <dustin@sensoria.com> wrote: > > This patch adds support for the SMSC LAN911x line of Ethernet chips. These > Ethernet controllers are a completely new register set from the old 91c9x > and 91c911x parts. This driver has been tested using a PXA255 host > processor, but has not been tested under other architectures. The driver > was written in a hopefully generic enough way to extend support beyond just > the ARM. I'm hoping for comments regarding its suitability for inclusion > into the kernel tree.
The patch was badly wordwrapped. Please fix and resend.
I'd suggest that you enable it on all architectures, not just CONFIG_ARM. Tht way we'll at least get compile coverage.
Coding style problems:
- The code uses four-spaces where it should be using hard tabs. Linux style is to always use hard tabs.
- The code does this:
if( while(
Linux style is
if ( while (
- Try to keep everything inside the 80th column. (This is especially useful when sending wordwrapped patches ;)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |