Messages in this thread | | | Date | Sat, 15 Apr 2006 13:51:03 +0200 | From | Adrian Bunk <> | Subject | Re: [patch 04/22] isd200: limit to BLK_DEV_IDE |
| |
On Thu, Apr 13, 2006 at 09:58:36PM -0400, Jeff Garzik wrote: > Greg KH wrote: > >-stable review patch. If anyone has any objections, please let us know. > > > >------------------ > > > >From: Randy Dunlap <rdunlap@xenotime.net> > > > >Limit USB_STORAGE_ISD200 to whatever BLK_DEV_IDE and USB_STORAGE > >are set to (y, m) since isd200 calls ide_fix_driveid() in the > >BLK_DEV_IDE code. > > > >Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> > >Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > > >--- > > drivers/usb/storage/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >--- linux-2.6.16.5.orig/drivers/usb/storage/Kconfig > >+++ linux-2.6.16.5/drivers/usb/storage/Kconfig > >@@ -48,7 +48,8 @@ config USB_STORAGE_FREECOM > > > > config USB_STORAGE_ISD200 > > bool "ISD-200 USB/ATA Bridge support" > >- depends on USB_STORAGE && BLK_DEV_IDE > >+ depends on USB_STORAGE > >+ depends on BLK_DEV_IDE=y || BLK_DEV_IDE=USB_STORAGE > > Wouldn't 'select' be more appropriate for IDE?
Your suggestion sounds like a good idea for 2.6.17, but for -stable I'd prefer this patch.
What bothers me more is that this doesn't seem to be fixed in any way in Linus' tree...
> Jeff
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |