Messages in this thread |  | | | From | Ingo Oeser <> | | Subject | Re: [PATCH] deinline a few large functions in vlan code v2 | | Date | Thu, 13 Apr 2006 13:32:50 +0200 |
| |
Hi Dave,
On Wednesday, 12. April 2006 19:18, Dave Dillow wrote: > you've left the spin_locks in, and have more #ifdefs.
Ok, I can refactor your driver to even remove this and reduce it to exaxtly two ifdef sections for your driver. Acceptable?
> Regardless, I remain opposed to this particular instance of bloat > busting. While both patches have improved in style, they remove a useful > feature and make the code less clean, for no net gain.
s/useful feature/unreachable code/g
> On SMP FC4, typhoon.ko has a text size of 68330, so you need to cut 2794 > bytes to see an actual difference in memory usage for a module. Non-SMP > it is 67741, so there you only need to cut 2205 bytes to get a win.
text data bss dec hex filename 62079 973 4 63056 f650 no-vlan/drivers/net/typhoon.o 62654 973 4 63631 f88f vlan/drivers/net/typhoon.o
with allyesconfig (minus CONFIG_INFO) and my patches applied. So maybe the uninlining is enough. Gain after this is just 575 bytes here.
Regards
Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |