Messages in this thread | | | Date | Wed, 12 Apr 2006 16:06:19 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] support for panic at OOM |
| |
Hi,
On Tue, 11 Apr 2006 23:59:07 -0700 Andrew Morton <akpm@osdl.org> wrote:
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > > > > This patch adds a feature to panic at OOM, oom_die. > > Makes sense I guess. > Thanks,
> > @@ -718,6 +719,14 @@ static ctl_table vm_table[] = { > > .proc_handler = &proc_dointvec, > > }, > > { > > + .ctl_name = VM_OOM_DIE, > > + .procname = "oom_die", > > I'd suggest it be called "panic_on_oom". Like the current panic_on_oops. > I'll chage.
> > +int sysctl_oom_die = 0; > > The initialisation is unneeded. > Okay,
> > + if (sysctl_oom_die) > > + oom_die(); > > I don't think we need a separate function for this? > Hmm.. okay. I'll put panic("Panic: out of memory: panic_on_oom is 1.") directly.
> Please document the new sysctl in Documentation/sysctl/. > I'll do.
Thanks, -Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |