lkml.org 
[lkml]   [2006]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] fix de_thread() vs do_coredump() deadlock
    Date
    > I still think we are ok with no ptrace. If that (non-coredump) signal was
    > delivered before de_thread sets SIGNAL_GROUP_EXIT, then this flag is set
    > by __group_complete_signal(), so de_thread return -EAGAIN. If de_thread()
    > wins, the signal will be dequeued later from ->shared_pending.

    There is no guarantee that __group_complete_signal gets to that code path
    when the signal is generated. There may be no thread that doesn't have it
    blocked nor is already descheduled with pending signals. Then some thread
    gets scheduled, or changes it signal mask, and then gets into
    get_signal_to_deliver and takes the siglock either before an exec'ing
    thread gets the lock, or while the exec'ing thread releases it to wait.
    When the dequeuer thread releases the siglock, we have the race window.
    (There is another similar case if the signal was handled at generation time
    and the handler is reset to SIG_DFL later in a race with another thread
    dequeuing the signal and a third doing an exec.)


    Thanks,
    Roland

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-11 11:52    [W:0.021 / U:0.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site