Messages in this thread | | | Subject | Re: [PATCH] de_thread: Don't confuse users do_each_thread. | From | (Eric W. Biederman) | Date | Tue, 11 Apr 2006 01:36:13 -0600 |
| |
Ingo Oeser <ioe-lkml@rameria.de> writes:
> On Tuesday, 11. April 2006 12:19, Oleg Nesterov wrote: >> On 04/11, Ingo Oeser wrote: >> > >> > While you are at it: Could you please avoid calculating current over >> > and over again? >> > >> > Just calculate it once and use the task_struct pointer. >> >> Ironically, de_thread() has 'tsk' parameter which is equal to 'current'. > > That's the thing that made me doubt :-) > > But thinking more about it: current cannot change within one thread, > right? So all of this can be cleaned up. > > I'll clean them up tonight and sent out a patch against current -mm.
Please skip de_thread. I will catch that one, in a minute. There is enough churn on that function that you are likely to patch the wrong version.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |