lkml.org 
[lkml]   [2006]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] de_thread: Don't confuse users do_each_thread.
    On 04/10, Andrew Morton wrote:
    >
    > Oleg Nesterov <oleg@tv-sign.ru> wrote:
    > >
    > > Currently I don't know how the code looks in -mm tree,
    >
    > http://www.zip.com.au/~akpm/linux/patches/stuff/x.bz2 is -mm-as-of-now.

    Thanks. Here is the patch:

    [PATCH] de_thread: fix lockless do_each_thread

    We should keep the value of old_leader->tasks.next in de_thread,
    otherwise we can't do for_each_process/do_each_thread without
    tasklist_lock held.

    Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

    --- mm/fs/exec.c~ 2006-04-11 14:31:18.000000000 +0400
    +++ mm/fs/exec.c 2006-04-11 14:35:23.000000000 +0400
    @@ -725,7 +725,7 @@ static int de_thread(struct task_struct
    attach_pid(current, PIDTYPE_PID, current->pid);
    attach_pid(current, PIDTYPE_PGID, current->signal->pgrp);
    attach_pid(current, PIDTYPE_SID, current->signal->session);
    - list_add_tail_rcu(&current->tasks, &init_task.tasks);
    + list_replace_rcu(&leader->tasks, &current->tasks);

    current->parent = current->real_parent = leader->real_parent;
    leader->parent = leader->real_parent = child_reaper;
    @@ -735,7 +735,6 @@ static int de_thread(struct task_struct
    /* Reduce leader to a thread */
    detach_pid(leader, PIDTYPE_PGID);
    detach_pid(leader, PIDTYPE_SID);
    - list_del_init(&leader->tasks);

    add_parent(current);
    add_parent(leader);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-11 08:52    [W:0.023 / U:33.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site