lkml.org 
[lkml]   [2006]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH rc1-mm 1/3] coredump: some code relocations
Date
> This is a preparation for the next patch. No functional changes.
> Basically, this patch moves '->flags & SIGNAL_GROUP_EXIT' check
> into zap_threads(), and 'complete(vfork_done)' into coredump_wait
> outside of ->mmap_sem protected area.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

I don't see anything especially wrong with these reorganizations. I'd
prefer if the commentary for the change indicated what about them was
required for the following patches. Making zap_threads have a return value
does seem sort of random and obfuscatory, but that is a minor nit.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-10 08:59    [W:0.079 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site