lkml.org 
[lkml]   [2006]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] deinline a few large functions in vlan code
From
From: Denis Vlasenko <vda@ilport.com.ua>
Date: Mon, 10 Apr 2006 08:28:20 +0300

> IOW: shouldn't calls to these functions sit in
> #if defined(CONFIG_VLAN_8021Q) || defined (CONFIG_VLAN_8021Q_MODULE)
> block? For example, typhoon.c:
>
> spin_lock(&tp->state_lock);
> +#if defined(CONFIG_VLAN_8021Q) || defined (CONFIG_VLAN_8021Q_MODULE)
> if(tp->vlgrp != NULL && rx->rxStatus & TYPHOON_RX_VLAN)
> vlan_hwaccel_receive_skb(new_skb, tp->vlgrp,
> ntohl(rx->vlanTag) & 0xffff);
> else
> +#endif
> netif_receive_skb(new_skb);
> spin_unlock(&tp->state_lock);
>
> Same for s2io.c, chelsio/sge.c, etc...

Very likely yes. tp->vlgrp will never be non-NULL in such situations
so it's not a correctness issue, but rather an optimization :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-10 07:48    [W:0.077 / U:1.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site