Messages in this thread | | | From | Denis Vlasenko <> | Subject | Re: [PATCH] deinline a few large functions in vlan code | Date | Mon, 10 Apr 2006 08:28:20 +0300 |
| |
On Friday 07 April 2006 23:25, David S. Miller wrote: > From: Denis Vlasenko <vda@ilport.com.ua> > Date: Fri, 7 Apr 2006 16:28:30 +0300 > > > What should be done with this? > > 1) Should I add respective select statements into Kconfigs > > of those drivers? > > 2) Make vlan_dev non-modular? > > 3) Move functions to another .c file? > > 4) Leave it inline.
Ok, I will leave them alone for now.
BTW, does it make any sense for a network driver to call these functions in non-VLAN-enbled kernel?
IOW: shouldn't calls to these functions sit in #if defined(CONFIG_VLAN_8021Q) || defined (CONFIG_VLAN_8021Q_MODULE) block? For example, typhoon.c:
spin_lock(&tp->state_lock); +#if defined(CONFIG_VLAN_8021Q) || defined (CONFIG_VLAN_8021Q_MODULE) if(tp->vlgrp != NULL && rx->rxStatus & TYPHOON_RX_VLAN) vlan_hwaccel_receive_skb(new_skb, tp->vlgrp, ntohl(rx->vlanTag) & 0xffff); else +#endif netif_receive_skb(new_skb); spin_unlock(&tp->state_lock);
Same for s2io.c, chelsio/sge.c, etc... -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |