Messages in this thread | | | Subject | Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management | From | Roland Dreier <> | Date | Thu, 09 Mar 2006 16:52:47 -0800 |
| |
Bryan> It's read outside of this file, without a lock held.
I missed the other reference in another patch. But the central point still stands: if all you do is atomic_set() and atomic_read(), then using atomic_t doesn't buy you anything. Just look at what atomic_read() expands to -- using it isn't protecting you against anything, so either you have a race, or you were safe without atomic_t. The only point to atomic_t is so that you can safely do read-modify-write things like atomic_inc().
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |