[lkml]   [2006]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4 of 20] ipath - support for HyperTransport devices
On Thu, 2006-03-09 at 15:01 -0800, Roland Dreier wrote:

> It seems like all these hypertransport magic constants should be in a
> general .h somewhere. I'm not sure if it makes sense to put them in
> <linux/pci.h>, or start a <linux/hypertransport.h>.

Either way is fine by me.

> The logic here is pretty hard to follow, and you're getting squeezed
> pretty hard by indenting 5 tabs stops. Can ipath_setup_ht_config() be
> split up into subfunctions?

Definitely. I mentioned this in the introductory message for the series
as something I'm working on.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-03-10 00:24    [W:0.648 / U:0.488 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site