lkml.org 
[lkml]   [2006]   [Mar]   [9]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 09 Mar 2006 19:18:21 +0300
FromKirill Korotaev <>
SubjectRe: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
> Thanks! I'll send the corrected patch.> So, everythings fine now?
looks so! Will be glad to Ack/Sign or whatever needed :)))

>>>	d_free(dentry);
>>>	if (parent != dentry)
>>>		dput(parent);
>>>	spin_lock(&dcache_lock);
>>>+	sb->s_prunes--;
>>>+	if (likely(!sb->s_prunes))>>>><<< Is it possibe to do something like:
>>if (unlikely(!sb->s_root && !sb->s_prunes))
>>?> > > Uh, I forgot about that one. You already complained about that before :(
But I'm not sure it is that simple... s_root is set to NULL w/o locks, 
so I wonder whether it is safe to check it here or we can miss some 
wakeups...

Thanks,
Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-09 16:16    [from the cache]
©2003-2008