lkml.org 
[lkml]   [2006]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table)
Date
On Thursday 09 March 2006 13:00, Andrew Morton wrote:
> Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> > + /* we can use kmalloc() in run time */
> > + do {
> > + table_size = zone->wait_table_size
> > + * sizeof(wait_queue_head_t);
> > + zone->wait_table = kmalloc(table_size, GFP_ATOMIC);
>
> Again, GFP_KERNEL would be better is possible.
>
> Won't this place the node's wait_table into a different node's memory?

Yes, kmalloc_node would be better.

-Andi


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-09 13:25    [W:0.161 / U:0.200 seconds]
©2003-2011 Jasper Spaans. Advertise on this site