lkml.org 
[lkml]   [2006]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[-mm patch] add a prototype for v9fs_printfcall()
On Tue, Mar 07, 2006 at 02:19:29AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc3-mm2:
>...
> +v9fs-print-9p-messages.patch
>...
> Misc updates and fixes
>...

If you create a function in one file and call them from another file you
need a prototype in a header file or bad runtime errors can occur in
some cases.

You mustn't ignore warnings about implicitely defined functions.
This bug was found by the gcc -Werror-implicit-function-declaration flag
that turns such warnings into errors.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.16-rc5-mm3-full/fs/9p/9p.h.old 2006-03-07 13:31:13.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/fs/9p/9p.h 2006-03-07 13:32:08.000000000 +0100
@@ -372,3 +372,6 @@
int v9fs_t_write(struct v9fs_session_info *v9ses, u32 fid, u64 offset,
u32 count, const char __user * data,
struct v9fs_fcall **rcall);
+
+int v9fs_printfcall(char *buf, int buflen, struct v9fs_fcall *fc, int extended);
+
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-08 10:11    [from the cache]
©2003-2011 Jasper Spaans