Messages in this thread | | | Date | Thu, 9 Mar 2006 00:46:26 +0100 | From | Adrian Bunk <> | Subject | Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation |
| |
On Wed, Mar 08, 2006 at 07:47:43PM -0300, Mauro Carvalho Chehab wrote: > Adrian, > > > Em Qua, 2006-03-08 às 22:19 +0100, Adrian Bunk escreveu: > > On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote: > > > > > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value is > > > checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the maximum > > > value in v4l2_queryctrl is set to 255 for both of these items. This > > > means that programs (like MythTV) which set the contrast and saturation > > > to the midvalue (127) get *full* contrast and saturation. (It's not > > > pretty.) > > > > > > Setting the maximum values to 127 solves this problem. > > > > Mauro, can you comment on this issue? > Yes. Patch is already available at both git and mercurial trees, fixing > it for saa7115 and cx25840: > > http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b77c2f933b620bccaa751d556c1aa2fca30de7ec;style=gitweb
This patch seems to be 2.1.16 stuff?
> Cheers, > Mauro.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |