lkml.org 
[lkml]   [2006]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [v4l-dvb-maintainer] Re: drivers/media/video/saa7115.c misreports max. value of contrast and saturation
    Date
    On Wednesday 08 March 2006 22:19, Adrian Bunk wrote:
    > On Wed, Feb 15, 2006 at 12:19:08AM -0500, Kyler Laird wrote:
    > > For changes to V4L2_CID_CONTRAST and V4L2_CID_SATURATION, the value
    > > is checked by "if (ctrl->value < 0 || ctrl->value > 127)" yet the
    > > maximum value in v4l2_queryctrl is set to 255 for both of these
    > > items. This means that programs (like MythTV) which set the
    > > contrast and saturation to the midvalue (127) get *full* contrast
    > > and saturation. (It's not pretty.)
    > >
    > > Setting the maximum values to 127 solves this problem.
    >
    > Mauro, can you comment on this issue?

    It's fixed with the patch with subject '[PATCH 08/13] Fix maximum for
    the saturation and contrast controls.' It was posted by Mauro to the
    linux mailinglist a week ago. I hope it will be fixed in 2.6.16, but
    Mauro should know more about it. It was a stupid copy-and-paste bug so
    I see no reason why it shouldn't go in.

    > > Please copy me on responses.
    > >
    > > Thank you.
    > >
    > > --kyler
    >
    > cu
    > Adrian
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-08 22:46    [W:0.059 / U:60.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site