Messages in this thread | | | Date | Wed, 8 Mar 2006 15:36:42 -0500 | From | Benjamin LaHaise <> | Subject | Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh |
| |
On Wed, Mar 08, 2006 at 12:26:56PM -0800, Ravikiran G Thirumalai wrote: > +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long amount) > +{ > + local_bh_disable(); > + fbc->count += amount; > + local_bh_enable(); > +}
Please use local_t instead, then you don't have to do the local_bh_disable() and enable() and the whole thing collapses down into 1 instruction on x86.
-ben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |