Messages in this thread | | | Date | Wed, 08 Mar 2006 23:09:49 +0900 (JST) | Subject | Re: [PATCH] crypto: alignment fixes | From | Atsushi Nemoto <> |
| |
>>>>> On Wed, 8 Mar 2006 21:27:31 +1100, Herbert Xu <herbert@gondor.apana.org.au> said: >> This patch fixes some alignment problem on crypto modules.
herbert> Thanks for the patch. Please split this up and cc herbert> linux-crypto@vger.kernel.org.
OK, I'll send soon.
>> 1. Many cipher setkey functions load key words directly but the key >> words might not be aligned. Enforce correct alignment in the >> setkey wrapper.
herbert> This isn't right. The alignmask applies to herbert> source/destination buffers only. The only requirement on the herbert> key is that it must always be 32-bit aligned.
Thank you for clarification. The tcrypt module breaks this requirement currently. I'll fix tcrypt.
>> 3. Some hash modules (and sha_transform() library function) >> load/store data words directly. Use >> get_unaligned()/put_unaligned() for them.
herbert> We should extend alignmask to cover this and handle it in the herbert> digest layer.
OK, I'll try it. Thank you.
--- Atsushi Nemoto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |