Messages in this thread | | | From | Dave Peterson <> | Subject | Re: [PATCH] EDAC: core EDAC support code | Date | Tue, 7 Mar 2006 16:29:28 -0800 |
| |
On Tuesday 07 March 2006 09:20, Greg KH wrote: > > Ok, I assume the comment refers to the following: > > > > Attributes should be ASCII text files, preferably with only one value > > per file. It is noted that it may not be efficient to contain only > > value per file, so it is socially acceptable to express an array of > > values of the same type. > > > > I was initially a bit confused because I thought the comment > > specifically pertained to the piece of code shown above. I need to > > take a closer look at the EDAC sysfs code - I'm not as familiar with > > some of its details as I should be. Thanks for pointing out the > > issue. > > How else should we word the above text so that people realize that it > pertains to them? You aren't the first person to ignore it, so there is > a real problem here :(
I think it's written clearly as it is. I didn't write the sysfs-specific parts of the EDAC code. However I'll take the blame for not having reviewed it more carefully before it went upstream. I guess my attention has been divided among too many things lately. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |