lkml.org 
[lkml]   [2006]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    >>The code changes look big, have you looked at
    >>http://marc.theaimsgroup.com/?l=linux-kernel&m=113817279225962&w=2
    >
    >
    > No I haven't. I like it.
    > - Holding the semaphore shouldn't be a problem.
    > - calling down_read_trylock ought to be fast
    > - I *think* the unwanted calls to prune_dcache are always under
    > PF_MEMALLOC - they certainly seem to be.
    No, it looks as it is not :(
    Have you noticed my comment about "count" argument to prune_dcache()?
    For example, prune_dcache() is called from shrink_dcache_parent() which
    is called in many places and not all of them have PF_MEMALLOC or
    s_umount semaphore for write. But prune_dcache() doesn't care for super
    blocks etc. It simply shrinks N dentries which are found _first_.

    So the condition:
    + if ((current->flags & PF_MEMALLOC) &&
    + !(ret = down_read_trylock(&s->s_umount))) {
    is not always true when the race occurs, as PF_MEMALLOC is not always set.

    > And it is a nice small change.
    > Have you had any other feedback on this?
    here it is :)

    Thanks,
    Kirill

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-07 07:14    [W:0.033 / U:93.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site