lkml.org 
[lkml]   [2006]   [Mar]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 6 Mar 2006 10:14:30 +0100
FromIngo Molnar <>
SubjectRe: Fw: Re: oops in choose_configuration()
* Linus Torvalds <torvalds@osdl.org> wrote:

> @@ -4028,6 +4028,8 @@ static inline void __cond_resched(void)
>  	 */
>  	if (unlikely(preempt_count()))
>  		return;
> +	if (unlikely(system_state != SYSTEM_RUNNING))
> +		return;

we used to have this, but it was frowned upon during the initial lkml 
review of -VP so i fixed all the known 'early bootup scheduling 
assumptions' and removed this condition .. but that was a losing battle 
i suspect. In any case, i fully agree with your fix. We also need this 
fix for v2.6.16.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-06 12:12    [from the cache]
©2003-2008