Messages in this thread | | | Date | Mon, 6 Mar 2006 19:20:13 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Slab corruption in 2.6.16-rc5-mm2 |
| |
On Mon, 6 Mar 2006, Mike Christie wrote: > - buffer = kmalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > + buffer = kzalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > if (!buffer) > return -ENOMEM; > > - memset(&cgc, 0, sizeof(struct packet_command)); ... > - buffer = kmalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > + buffer = kzalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > if (!buffer) > return -ENOMEM; > > - memset(&cgc, 0, sizeof(struct packet_command));
> When someone converted the *buffer* allocation to kzalloc they > also removed the the memset for the *packet_cmmand* struct. > > The > > memset(&cgc, 0, sizeof(struct packet_command)); > > should be added back I think.
Good eyes. I bet that's it.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |