lkml.org 
[lkml]   [2006]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Slab corruption in 2.6.16-rc5-mm2


On Mon, 6 Mar 2006, Mike Christie wrote:
> - buffer = kmalloc(32, GFP_KERNEL | SR_GFP_DMA(cd));
> + buffer = kzalloc(32, GFP_KERNEL | SR_GFP_DMA(cd));
> if (!buffer)
> return -ENOMEM;
>
> - memset(&cgc, 0, sizeof(struct packet_command));
...
> - buffer = kmalloc(32, GFP_KERNEL | SR_GFP_DMA(cd));
> + buffer = kzalloc(32, GFP_KERNEL | SR_GFP_DMA(cd));
> if (!buffer)
> return -ENOMEM;
>
> - memset(&cgc, 0, sizeof(struct packet_command));

> When someone converted the *buffer* allocation to kzalloc they
> also removed the the memset for the *packet_cmmand* struct.
>
> The
>
> memset(&cgc, 0, sizeof(struct packet_command));
>
> should be added back I think.

Good eyes. I bet that's it.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.221 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site