lkml.org 
[lkml]   [2006]   [Mar]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH 1/6] prepare sysctls for containers
FromDave Hansen <>
DateMon, 06 Mar 2006 17:55:48 -0800
On Tue, 2006-03-07 at 01:24 +0000, Al Viro wrote:
> This is disgusting.  Please, don't pile more and more complexity into
> sysctl_table - it's already choke-full of it and needs to be simplified,
> not to grow more crap.
I don't completely disagree.  It certainly isn't the most elegant
approach I've ever seen.

Any ideas on ways we could simplify it?  I was thinking that we could
get rid of the .data member and allow access only via the mechanism I
just introduced.  It would be pretty easy to make some macros to
generate "simple" access functions for the existing global variables.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-07 01:59    [W:0.249 / U:0.030 seconds]
©2003-2008 Jasper Spaans